[llvm-commits] [llvm] r106029 - in /llvm/trunk/test: CodeGen/ARM/ CodeGen/Thumb2/ Transforms/ScalarRepl/
Bob Wilson
bob.wilson at apple.com
Tue Jun 15 13:44:09 PDT 2010
I think I mentioned this in another message, but this is changing the behavior of at least some of these tests. For example, the first one has a target triple of "armv6-elf", which as far as I can tell, has a default ABI of APCS. So you've changed that test to use APCS instead of AAPCS.
Unless you think there's a problem with the tests, it would be better to avoid random changes that may prevent them from testing what they were intended to test.
On Jun 15, 2010, at 12:04 PM, Rafael Espindola wrote:
> Author: rafael
> Date: Tue Jun 15 14:04:29 2010
> New Revision: 106029
>
> URL: http://llvm.org/viewvc/llvm-project?rev=106029&view=rev
> Log:
> Remove the arm_aapcscc marker from the tests. It is the default
> for the linux targets.
>
> Modified:
> llvm/trunk/test/CodeGen/ARM/2009-08-04-RegScavengerAssert-2.ll
> llvm/trunk/test/CodeGen/ARM/2009-08-04-RegScavengerAssert.ll
> llvm/trunk/test/CodeGen/ARM/2009-08-15-RegScavenger-EarlyClobber.ll
> llvm/trunk/test/CodeGen/ARM/2009-08-15-RegScavengerAssert.ll
> llvm/trunk/test/CodeGen/ARM/2009-09-28-LdStOptiBug.ll
> llvm/trunk/test/CodeGen/ARM/2009-10-27-double-align.ll
> llvm/trunk/test/CodeGen/ARM/arm-frameaddr.ll
> llvm/trunk/test/CodeGen/ARM/armv4.ll
> llvm/trunk/test/CodeGen/Thumb2/2009-08-04-CoalescerAssert.ll
> llvm/trunk/test/CodeGen/Thumb2/2009-08-06-SpDecBug.ll
> llvm/trunk/test/CodeGen/Thumb2/2009-08-08-ScavengerAssert.ll
> llvm/trunk/test/Transforms/ScalarRepl/memcpy-align.ll
>
> Modified: llvm/trunk/test/CodeGen/ARM/2009-08-04-RegScavengerAssert-2.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/2009-08-04-RegScavengerAssert-2.ll?rev=106029&r1=106028&r2=106029&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/2009-08-04-RegScavengerAssert-2.ll (original)
> +++ llvm/trunk/test/CodeGen/ARM/2009-08-04-RegScavengerAssert-2.ll Tue Jun 15 14:04:29 2010
> @@ -4,7 +4,7 @@
> target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:32-f32:32:32-f64:32:32-v64:64:64-v128:128:128-a0:0:64"
> target triple = "armv6-elf"
>
> -define arm_aapcscc i32 @file_read_actor(i32* nocapture %desc, i32* %page, i32 %offset, i32 %size) nounwind optsize {
> +define i32 @file_read_actor(i32* nocapture %desc, i32* %page, i32 %offset, i32 %size) nounwind optsize {
> entry:
> br i1 undef, label %fault_in_pages_writeable.exit, label %bb5.i
>
> @@ -26,8 +26,8 @@
> unreachable
>
> bb3: ; preds = %fault_in_pages_writeable.exit
> - %1 = tail call arm_aapcscc i32 @__copy_to_user(i8* undef, i8* undef, i32 undef) nounwind ; <i32> [#uses=0]
> + %1 = tail call i32 @__copy_to_user(i8* undef, i8* undef, i32 undef) nounwind ; <i32> [#uses=0]
> unreachable
> }
>
> -declare arm_aapcscc i32 @__copy_to_user(i8*, i8*, i32)
> +declare i32 @__copy_to_user(i8*, i8*, i32)
>
> Modified: llvm/trunk/test/CodeGen/ARM/2009-08-04-RegScavengerAssert.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/2009-08-04-RegScavengerAssert.ll?rev=106029&r1=106028&r2=106029&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/2009-08-04-RegScavengerAssert.ll (original)
> +++ llvm/trunk/test/CodeGen/ARM/2009-08-04-RegScavengerAssert.ll Tue Jun 15 14:04:29 2010
> @@ -1,7 +1,7 @@
> ; RUN: llc < %s -mtriple=armv6-elf
> ; PR4528
>
> -define arm_aapcscc i32 @file_read_actor(i32 %desc, i32 %page, i32 %offset, i32 %size) nounwind optsize {
> +define i32 @file_read_actor(i32 %desc, i32 %page, i32 %offset, i32 %size) nounwind optsize {
> entry:
> br i1 undef, label %fault_in_pages_writeable.exit, label %bb5.i
>
> @@ -18,8 +18,8 @@
> unreachable
>
> bb3: ; preds = %fault_in_pages_writeable.exit
> - %2 = tail call arm_aapcscc i32 @__copy_to_user(i8* undef, i8* undef, i32 undef) nounwind ; <i32> [#uses=0]
> + %2 = tail call i32 @__copy_to_user(i8* undef, i8* undef, i32 undef) nounwind ; <i32> [#uses=0]
> unreachable
> }
>
> -declare arm_aapcscc i32 @__copy_to_user(i8*, i8*, i32)
> +declare i32 @__copy_to_user(i8*, i8*, i32)
>
> Modified: llvm/trunk/test/CodeGen/ARM/2009-08-15-RegScavenger-EarlyClobber.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/2009-08-15-RegScavenger-EarlyClobber.ll?rev=106029&r1=106028&r2=106029&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/2009-08-15-RegScavenger-EarlyClobber.ll (original)
> +++ llvm/trunk/test/CodeGen/ARM/2009-08-15-RegScavenger-EarlyClobber.ll Tue Jun 15 14:04:29 2010
> @@ -6,7 +6,7 @@
> %struct.device_dma_parameters = type { i32, i32 }
> %struct.iovec = type { i8*, i32 }
>
> -define arm_aapcscc i32 @generic_segment_checks(%struct.iovec* nocapture %iov, i32* nocapture %nr_segs, i32* nocapture %count, i32 %access_flags) nounwind optsize {
> +define i32 @generic_segment_checks(%struct.iovec* nocapture %iov, i32* nocapture %nr_segs, i32* nocapture %count, i32 %access_flags) nounwind optsize {
> entry:
> br label %bb8
>
>
> Modified: llvm/trunk/test/CodeGen/ARM/2009-08-15-RegScavengerAssert.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/2009-08-15-RegScavengerAssert.ll?rev=106029&r1=106028&r2=106029&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/2009-08-15-RegScavengerAssert.ll (original)
> +++ llvm/trunk/test/CodeGen/ARM/2009-08-15-RegScavengerAssert.ll Tue Jun 15 14:04:29 2010
> @@ -1,10 +1,10 @@
> ; RUN: llc < %s -march=arm
> ; PR4716
>
> -define arm_aapcscc void @_start() nounwind naked {
> +define void @_start() nounwind naked {
> entry:
> - tail call arm_aapcscc void @exit(i32 undef) noreturn nounwind
> + tail call void @exit(i32 undef) noreturn nounwind
> unreachable
> }
>
> -declare arm_aapcscc void @exit(i32) noreturn nounwind
> +declare void @exit(i32) noreturn nounwind
>
> Modified: llvm/trunk/test/CodeGen/ARM/2009-09-28-LdStOptiBug.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/2009-09-28-LdStOptiBug.ll?rev=106029&r1=106028&r2=106029&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/2009-09-28-LdStOptiBug.ll (original)
> +++ llvm/trunk/test/CodeGen/ARM/2009-09-28-LdStOptiBug.ll Tue Jun 15 14:04:29 2010
> @@ -3,7 +3,7 @@
>
> %0 = type { double, double }
>
> -define arm_aapcscc void @foo(%0* noalias nocapture sret %agg.result, double %x.0, double %y.0) nounwind {
> +define void @foo(%0* noalias nocapture sret %agg.result, double %x.0, double %y.0) nounwind {
> ; CHECK: foo:
> ; CHECK: bl __adddf3
> ; CHECK-NOT: strd
>
> Modified: llvm/trunk/test/CodeGen/ARM/2009-10-27-double-align.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/2009-10-27-double-align.ll?rev=106029&r1=106028&r2=106029&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/2009-10-27-double-align.ll (original)
> +++ llvm/trunk/test/CodeGen/ARM/2009-10-27-double-align.ll Tue Jun 15 14:04:29 2010
> @@ -2,13 +2,13 @@
>
> @.str = private constant [1 x i8] zeroinitializer, align 1
>
> -define arm_aapcscc void @g() {
> +define void @g() {
> entry:
> ;CHECK: [sp, #8]
> ;CHECK: [sp, #12]
> ;CHECK: [sp]
> - tail call arm_aapcscc void (i8*, ...)* @f(i8* getelementptr ([1 x i8]* @.str, i32 0, i32 0), i32 1, double 2.000000e+00, i32 3, double 4.000000e+00)
> + tail call void (i8*, ...)* @f(i8* getelementptr ([1 x i8]* @.str, i32 0, i32 0), i32 1, double 2.000000e+00, i32 3, double 4.000000e+00)
> ret void
> }
>
> -declare arm_aapcscc void @f(i8*, ...)
> +declare void @f(i8*, ...)
>
> Modified: llvm/trunk/test/CodeGen/ARM/arm-frameaddr.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/arm-frameaddr.ll?rev=106029&r1=106028&r2=106029&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/arm-frameaddr.ll (original)
> +++ llvm/trunk/test/CodeGen/ARM/arm-frameaddr.ll Tue Jun 15 14:04:29 2010
> @@ -3,7 +3,7 @@
> ; PR4344
> ; PR4416
>
> -define arm_aapcscc i8* @t() nounwind {
> +define i8* @t() nounwind {
> entry:
> ; DARWIN: t:
> ; DARWIN: mov r0, r7
>
> Modified: llvm/trunk/test/CodeGen/ARM/armv4.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/armv4.ll?rev=106029&r1=106028&r2=106029&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/armv4.ll (original)
> +++ llvm/trunk/test/CodeGen/ARM/armv4.ll Tue Jun 15 14:04:29 2010
> @@ -5,7 +5,7 @@
> ; RUN: llc < %s -mtriple=armv4-unknown-eabi | FileCheck %s -check-prefix=ARM
> ; RUN: llc < %s -mtriple=armv4t-unknown-eabi | FileCheck %s -check-prefix=THUMB
>
> -define arm_aapcscc i32 @test(i32 %a) nounwind readnone {
> +define i32 @test(i32 %a) nounwind readnone {
> entry:
> ; ARM: mov pc
> ; THUMB: bx
>
> Modified: llvm/trunk/test/CodeGen/Thumb2/2009-08-04-CoalescerAssert.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Thumb2/2009-08-04-CoalescerAssert.ll?rev=106029&r1=106028&r2=106029&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/Thumb2/2009-08-04-CoalescerAssert.ll (original)
> +++ llvm/trunk/test/CodeGen/Thumb2/2009-08-04-CoalescerAssert.ll Tue Jun 15 14:04:29 2010
> @@ -5,7 +5,7 @@
> %struct._IO_marker = type { %struct._IO_marker*, %struct.FILE*, i32 }
> @.str2 = external constant [30 x i8], align 1 ; <[30 x i8]*> [#uses=1]
>
> -define arm_aapcscc i32 @__mf_heuristic_check(i32 %ptr, i32 %ptr_high) nounwind {
> +define i32 @__mf_heuristic_check(i32 %ptr, i32 %ptr_high) nounwind {
> entry:
> br i1 undef, label %bb1, label %bb
>
> @@ -17,7 +17,7 @@
>
> bb2: ; preds = %bb1
> %0 = call i8* @llvm.frameaddress(i32 0) ; <i8*> [#uses=1]
> - %1 = call arm_aapcscc i32 (%struct.FILE*, i8*, ...)* @fprintf(%struct.FILE* noalias undef, i8* noalias getelementptr ([30 x i8]* @.str2, i32 0, i32 0), i8* %0, i8* null) nounwind ; <i32> [#uses=0]
> + %1 = call i32 (%struct.FILE*, i8*, ...)* @fprintf(%struct.FILE* noalias undef, i8* noalias getelementptr ([30 x i8]* @.str2, i32 0, i32 0), i8* %0, i8* null) nounwind ; <i32> [#uses=0]
> unreachable
>
> bb9: ; preds = %bb1
> @@ -26,4 +26,4 @@
>
> declare i8* @llvm.frameaddress(i32) nounwind readnone
>
> -declare arm_aapcscc i32 @fprintf(%struct.FILE* noalias nocapture, i8* noalias nocapture, ...) nounwind
> +declare i32 @fprintf(%struct.FILE* noalias nocapture, i8* noalias nocapture, ...) nounwind
>
> Modified: llvm/trunk/test/CodeGen/Thumb2/2009-08-06-SpDecBug.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Thumb2/2009-08-06-SpDecBug.ll?rev=106029&r1=106028&r2=106029&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/Thumb2/2009-08-06-SpDecBug.ll (original)
> +++ llvm/trunk/test/CodeGen/Thumb2/2009-08-06-SpDecBug.ll Tue Jun 15 14:04:29 2010
> @@ -2,12 +2,12 @@
> ; PR4659
> ; PR4682
>
> -define hidden arm_aapcscc i32 @__gcov_execlp(i8* %path, i8* %arg, ...) nounwind {
> +define hidden i32 @__gcov_execlp(i8* %path, i8* %arg, ...) nounwind {
> entry:
> ; CHECK: __gcov_execlp:
> ; CHECK: mov sp, r7
> ; CHECK: sub sp, #4
> - call arm_aapcscc void @__gcov_flush() nounwind
> + call void @__gcov_flush() nounwind
> br i1 undef, label %bb5, label %bb
>
> bb: ; preds = %bb, %entry
> @@ -15,10 +15,10 @@
>
> bb5: ; preds = %bb, %entry
> %0 = alloca i8*, i32 undef, align 4 ; <i8**> [#uses=1]
> - %1 = call arm_aapcscc i32 @execvp(i8* %path, i8** %0) nounwind ; <i32> [#uses=1]
> + %1 = call i32 @execvp(i8* %path, i8** %0) nounwind ; <i32> [#uses=1]
> ret i32 %1
> }
>
> -declare hidden arm_aapcscc void @__gcov_flush()
> +declare hidden void @__gcov_flush()
>
> -declare arm_aapcscc i32 @execvp(i8*, i8**) nounwind
> +declare i32 @execvp(i8*, i8**) nounwind
>
> Modified: llvm/trunk/test/CodeGen/Thumb2/2009-08-08-ScavengerAssert.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Thumb2/2009-08-08-ScavengerAssert.ll?rev=106029&r1=106028&r2=106029&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/Thumb2/2009-08-08-ScavengerAssert.ll (original)
> +++ llvm/trunk/test/CodeGen/Thumb2/2009-08-08-ScavengerAssert.ll Tue Jun 15 14:04:29 2010
> @@ -3,7 +3,7 @@
>
> @g_d = external global double ; <double*> [#uses=1]
>
> -define arm_aapcscc void @foo(float %yIncr) {
> +define void @foo(float %yIncr) {
> entry:
> br i1 undef, label %bb, label %bb4
>
>
> Modified: llvm/trunk/test/Transforms/ScalarRepl/memcpy-align.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/ScalarRepl/memcpy-align.ll?rev=106029&r1=106028&r2=106029&view=diff
> ==============================================================================
> --- llvm/trunk/test/Transforms/ScalarRepl/memcpy-align.ll (original)
> +++ llvm/trunk/test/Transforms/ScalarRepl/memcpy-align.ll Tue Jun 15 14:04:29 2010
> @@ -9,7 +9,7 @@
>
> @c = external global %0 ; <%0*> [#uses=1]
>
> -define arm_aapcscc void @good() nounwind {
> +define void @good() nounwind {
> entry:
> %x0 = alloca %struct.anon, align 4 ; <%struct.anon*> [#uses=2]
> %tmp = bitcast %struct.anon* %x0 to i8* ; <i8*> [#uses=1]
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
More information about the llvm-commits
mailing list