[llvm-commits] [patch] Remove arm_aapcscc from some tests

[Bob Wilson]

On Jun 15, 2010, at 12:30 PM, Rafael Espindola wrote:

>> I guess so.  I don't have any objections to your change as long as it doesn't break the tests.
> 
> The equivalent patch for apcs is attached. Is it OK?

I'm OK with it as long as the default ABI for non-Linux targets is APCS.  I took a quick look at it seems like that is true; AAPCS is only the default if the triple includes "eabi".  Otherwise, you're potentially changing the behavior of a lot of tests.  Even if those tests are not directly related to testing the ABI, there may be differences that affect what the tests do.

In light of that, I recommend you take another look at the test changes you made to remove "arm_aapcscc".  There were fewer of them, so it shouldn't be too hard.  Since you removed the ABI specifier, it would be a good idea to change those tests to use a target triple that defaults to AAPCS so that those tests continue testing what they were doing before.