[llvm-commits] [patch] X86FastISel can't handle loads through %fs or %gs

Chris Lattner clattner at apple.com
Tue Jun 15 12:09:00 PDT 2010


On Jun 14, 2010, at 6:25 PM, Nelson Elhage wrote:

> This patch causes X86FastIsel to bail out on loads through %fs or %gs
> (i.e. address spaces > 255), which lets us fall back to regular isel and
> correctly compile loads through those segment registers at -O0.
> 
> The addrspace(256) -> %GS feature is still buggy (See PR3966), but this
> seems like a strict improvement, and I expect that feature is used
> rarely enough that the performance cost of going through regular
> instruction selection is probably acceptable.

Looks great, applied in r106031!

-Chris



More information about the llvm-commits mailing list