[llvm-commits] Global Merge Pass for ARM

Anton Korobeynikov anton at korobeynikov.info
Fri Jun 4 03:19:56 PDT 2010

Hello, Evan

> The patch looks good in general. My concern with getMaximalGlobalOffset is it's too inflexible. It's basically only useful for G +/- offset address mode. Contrast it with isLegalAddressingMode(), it uses struct AddrMode, which can describe a different types of address modes. Any ideas?
That's correct. isLegalAddressingMode is even more inflexible and
cannot be used here since it's main target is load stores not the
maximal imm field allowed by the target. E.g. we might easily merge
arrays of structs while isLegalAddressingMode will return false in
this case.

With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University

More information about the llvm-commits mailing list