[llvm-commits] [llvm] r105453 - in /llvm/trunk: lib/CodeGen/SelectionDAG/LegalizeTypes.cpp test/CodeGen/X86/widen_shuffle-1.ll test/CodeGen/X86/widen_shuffle-2.ll

Duncan Sands baldrick at free.fr
Fri Jun 4 00:30:58 PDT 2010

Hi Mon Ping,

> Fixed a bug during widening where we would avoid legalizing a node.  When we
> replace an OpA with a widened OpB, it is possible to get new uses of OpA due to CSE
> when recursively updating nodes.  Since OpA has been processed, the new uses are
> not examined again.  The patch checks if this occurred and it it did, updates the
> new uses of OpA to use OpB.

this is an incredibly fragile bit of code.  It's almost impossible to touch it
without breaking something!  At a minimum, for testing you should configure LLVM
with *expensive checks enabled*, bootstrap gcc and run the entire testsuite.
That said I would rather you reverted this, and give me a few days to poke at
the testcase.



More information about the llvm-commits mailing list