[llvm-commits] [patch] Refactor getCalleeSavedRegClasses and getCalleeSavedRegs

Rafael Espindola espindola at google.com
Tue Jun 1 22:12:43 PDT 2010

> They should spill as VR128, and again that is the ultimate subclass:

True, that is what the x86 backend does now.

> I expect it to 'just work' if you change the definition of getPhysicalRegisterRegClass, but testing is in order, of course. Perhaps a new name is a good idea as well? getMinimalPhysRegClass?

I tested, and neon tests started failing. Not entirely sure why.

> The function has been around for a long time, and at some point a register was only allowed to exist in one register class.

So, attached is a first patch that might be useful in itself. What it
does is remove uses of getCalleeSavedRegClasses from outside the
backends and removes the virtual declaration. With that out of the way
I should be able to cleanup one backend at a time.

> /jakob

Rafael Ávila de Espíndola
-------------- next part --------------
A non-text attachment was scrubbed...
Name: virt.patch
Type: application/octet-stream
Size: 4036 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100602/56d4f884/attachment.obj>

More information about the llvm-commits mailing list