[llvm-commits] [llvm] r105274 - in /llvm/trunk: include/llvm/MC/MCStreamer.h lib/MC/MCAsmStreamer.cpp lib/MC/MCAssembler.cpp
Dan Gohman
gohman at apple.com
Tue Jun 1 09:31:34 PDT 2010
Author: djg
Date: Tue Jun 1 11:31:34 2010
New Revision: 105274
URL: http://llvm.org/viewvc/llvm-project?rev=105274&view=rev
Log:
Don't call flush() at a library level which isn't checking for errors
and doesn't know where the output is going.
Modified:
llvm/trunk/include/llvm/MC/MCStreamer.h
llvm/trunk/lib/MC/MCAsmStreamer.cpp
llvm/trunk/lib/MC/MCAssembler.cpp
Modified: llvm/trunk/include/llvm/MC/MCStreamer.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCStreamer.h?rev=105274&r1=105273&r2=105274&view=diff
==============================================================================
--- llvm/trunk/include/llvm/MC/MCStreamer.h (original)
+++ llvm/trunk/include/llvm/MC/MCStreamer.h Tue Jun 1 11:31:34 2010
@@ -314,7 +314,7 @@
virtual void EmitRawText(StringRef String);
void EmitRawText(const Twine &String);
- /// Finish - Finish emission of machine code and flush any output.
+ /// Finish - Finish emission of machine code.
virtual void Finish() = 0;
};
Modified: llvm/trunk/lib/MC/MCAsmStreamer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAsmStreamer.cpp?rev=105274&r1=105273&r2=105274&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCAsmStreamer.cpp (original)
+++ llvm/trunk/lib/MC/MCAsmStreamer.cpp Tue Jun 1 11:31:34 2010
@@ -693,7 +693,6 @@
}
void MCAsmStreamer::Finish() {
- OS.flush();
}
MCStreamer *llvm::createAsmStreamer(MCContext &Context,
Modified: llvm/trunk/lib/MC/MCAssembler.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAssembler.cpp?rev=105274&r1=105273&r2=105274&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCAssembler.cpp (original)
+++ llvm/trunk/lib/MC/MCAssembler.cpp Tue Jun 1 11:31:34 2010
@@ -759,7 +759,6 @@
// Write the object file.
Writer->WriteObject(*this, Layout);
- OS.flush();
stats::ObjectBytes += OS.tell() - StartOffset;
}
More information about the llvm-commits
mailing list