[llvm-commits] [llvm] r104419 - in /llvm/trunk: include/llvm/CodeGen/ISDOpcodes.h include/llvm/Intrinsics.td lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp lib/Target/ARM/ARMBaseInstrInfo.cpp lib/Target/ARM/ARMISelLowering.cpp lib/Target/ARM/ARMISelLowering.h lib/Target/ARM/ARMInstrInfo.td lib/Target/ARM/ARMInstrThumb.td

[John McCall]

On May 21, 2010, at 6:06 PM, Jim Grosbach wrote:
> Modified: llvm/trunk/include/llvm/Intrinsics.td
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Intrinsics.td?rev=104419&r1=104418&r2=104419&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/Intrinsics.td (original)
> +++ llvm/trunk/include/llvm/Intrinsics.td Fri May 21 20:06:18 2010
> @@ -306,11 +306,13 @@
> def int_eh_dwarf_cfa  : Intrinsic<[llvm_ptr_ty], [llvm_i32_ty]>;
> 
> let Properties = [IntrNoMem] in {
> -  def int_eh_sjlj_setjmp  : Intrinsic<[llvm_i32_ty],  [llvm_ptr_ty]>;
> -  def int_eh_sjlj_longjmp : Intrinsic<[], [llvm_ptr_ty]>;
> +  def int_eh_sjlj_setjmp  : Intrinsic<[llvm_i32_ty], [llvm_ptr_ty]>,
> +                                       GCCBuiltin<"__builtin_setjmp">;
>   def int_eh_sjlj_lsda    : Intrinsic<[llvm_ptr_ty]>;
>   def int_eh_sjlj_callsite: Intrinsic<[], [llvm_i32_ty]>;
> }
> +def int_eh_sjlj_longjmp : Intrinsic<[], [llvm_ptr_ty], [IntrWriteArgMem]>,
> +                                     GCCBuiltin<"__builtin_longjmp">;
> 
> //===---------------- Generic Variable Attribute Intrinsics----------------===//
> //
> 

Hey, Jim.  This breaks the assumption that Intrinsic::getIntrinsicForGCCBuiltin()
will return a function whose type is "reasonably similar" to the GCC builtin.
__builtin_longjmp() has the same signature as longjmp, i.e. it takes two arguments.

Clang actually relies on this assumption (<rdar://problem/8033657>), although
apparently we don't test IR gen for __builtin_longjmp in our test suite.

John.