[llvm-commits] [llvm] r104755 - /llvm/trunk/utils/TableGen/RegisterInfoEmitter.cpp

[Jakob Stoklund Olesen]

Author: stoklund
Date: Wed May 26 17:15:07 2010
New Revision: 104755

URL: http://llvm.org/viewvc/llvm-project?rev=104755&view=rev
Log:
Check that inherited subregisters all have a direct SubRegIndex.

Modified:
    llvm/trunk/utils/TableGen/RegisterInfoEmitter.cpp

Modified: llvm/trunk/utils/TableGen/RegisterInfoEmitter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/RegisterInfoEmitter.cpp?rev=104755&r1=104754&r2=104755&view=diff
==============================================================================
--- llvm/trunk/utils/TableGen/RegisterInfoEmitter.cpp (original)
+++ llvm/trunk/utils/TableGen/RegisterInfoEmitter.cpp Wed May 26 17:15:07 2010
@@ -186,7 +186,7 @@
   if (SubRegs.size() != Indices.size())
     throw "Register " + Reg->getName() + " SubRegIndices doesn't match SubRegs";
 
-  // First insert the direct subregs.
+  // First insert the direct subregs and make sure they are fully indexed.
   for (unsigned i = 0, e = SubRegs.size(); i != e; ++i) {
     if (!SRM.insert(std::make_pair(Indices[i], SubRegs[i])).second)
       throw "SubRegIndex " + Indices[i]->getName()
@@ -194,11 +194,18 @@
     inferSubRegIndices(SubRegs[i], ASRM);
   }
 
+  // Keep track of inherited subregs and how they can be reached.
+  // Register -> (SubRegIndex, SubRegIndex)
+  typedef std::map<Record*, std::pair<Record*,Record*>, LessRecord> OrphanMap;
+  OrphanMap Orphans;
+
   // Clone inherited subregs. Here the order is important - earlier subregs take
   // precedence.
   for (unsigned i = 0, e = SubRegs.size(); i != e; ++i) {
     SubRegMap &M = ASRM[SubRegs[i]];
-    SRM.insert(M.begin(), M.end());
+    for (SubRegMap::iterator si = M.begin(), se = M.end(); si != se; ++si)
+      if (!SRM.insert(*si).second)
+        Orphans[si->second] = std::make_pair(Indices[i], si->first);
   }
 
   // Finally process the composites.
@@ -228,6 +235,22 @@
 
     // Insert composite index. Allow overriding inherited indices etc.
     SRM[BaseIdxInit->getDef()] = R2;
+
+    // R2 is now directly addressable, no longer an orphan.
+    Orphans.erase(R2);
+  }
+
+  // Now, Orphans contains the inherited subregisters without a direct index.
+  if (!Orphans.empty()) {
+    errs() << "Error: Register " << getQualifiedName(Reg)
+           << " inherited subregisters without an index:\n";
+    for (OrphanMap::iterator i = Orphans.begin(), e = Orphans.end(); i != e;
+         ++i) {
+      errs() << "  " << getQualifiedName(i->first)
+             << " = " << i->second.first->getName()
+             << ", " << i->second.second->getName() << "\n";
+    }
+    abort();
   }
   return SRM;
 }