[llvm-commits] [llvm] r104653 - /llvm/trunk/lib/Target/ARM/ARMCodeEmitter.cpp

[Nick Lewycky]

Shih-wei Liao wrote:
> Thanks. Now I added a space. Please see the attached patch.
>
> (I didn't run "make check" or "make check-lit" on this.)

You don't need to, please just go ahead and commit. :) The line in the 
developer policy is:

"You are allowed to commit patches without approval which you think are 
obvious. This is clearly a subjective decision — we simply expect you to 
use good judgement. Examples include: fixing build breakage, reverting 
obviously broken patches, documentation/comment changes, any other minor 
changes."

Nick

> On Tue, May 25, 2010 at 9:28 PM, Anton Korobeynikov
> <anton at korobeynikov.info <mailto:anton at korobeynikov.info>> wrote:
>
>     Hello, Shih-wei
>      > +  } else if((TID.Opcode == ARM::BFC) || (TID.Opcode == ARM::BFI)) {
>     Please put a space between "if" and "("
>
>     Thanks!
>
>     --
>     With best regards, Anton Korobeynikov
>     Faculty of Mathematics and Mechanics, Saint Petersburg State University
>
>
>
>
> --
> Thanks,
>    Shih-wei
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits