[llvm-commits] [PATCH] [ARM JIT] To fix the missing implementation of ARM::UBFX and ARM::SBFX

Zonr Chang zonr.xchg at gmail.com
Tue May 25 20:14:06 PDT 2010


I just reviewed and tested this patch. Good job!
LGTM.

Zonr


On Wed, May 26, 2010 at 11:04 AM, Shih-wei Liao <sliao at google.com> wrote:

> Thanks to Zonr's and Nick's reviews, I removed "<< 0" to make the code look
> cleaner.
>
> Thanks to Zonr's review, I changed the notation from Instr[] to Instr{}.
> Please see the new patch.
>
>
> On Tue, May 25, 2010 at 5:59 PM, Shih-wei Liao <sliao at google.com> wrote:
>
>> Attached is the patch that will fix the bug
>> http://llvm.org/bugs/show_bug.cgi?id=7225.
>>
>> The patch passed "make check-lit" and "make check".
>>
>> Could someone please review it? Thanks.
>> --
>> Thanks,
>>   Shih-wei
>>
>
> --
> Thanks,
>   Shih-wei
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100526/6c65a374/attachment.html>


More information about the llvm-commits mailing list