[llvm-commits] [PATCH] To handle s* registers in emitVFPLoadStoreMultipleInstruction()

[Shih-wei Liao]

1. Fixed in r104652.

2. Passed "make check":
===  Summary ===

   # of expected passes 3841
   # of expected failures 24
   make[1]: Leaving directory `/usr/local/google/upstream/llvm-obj/test'

3. Passed "make check-lit":
   Expected Passes    : 4100
   Expected Failures  : 24
   Unsupported Tests  : 1184
   make[1]: Leaving directory `/usr/local/google/upstream/llvm-obj/test'

Thanks for the reviews. I'm learning the patching from you --- I called it
arm-jit-*.patch to follow your style.

On Tue, May 25, 2010 at 4:00 AM, Zonr Chang <zonr.xchg at gmail.com> wrote:

> I reviewed and tested this patch. Thanks for your hard working on reporting
> and resolving the bug in ARM JIT.
> LGTM.
>
> Zonr
>
> From: Shih-wei Liao <sliao at google.com>
>> Date: Tue, May 25, 2010 at 1:21 AM
>> Subject: [PATCH] To handle s* registers in
>> emitVFPLoadStoreMultipleInstruction()
>> To: llvm-commits <llvm-commits at cs.uiuc.edu>
>>
>>
>> Could someone review the patch in
>> http://llvm.org/bugs/show_bug.cgi?id=7221?
>>
>> --- lib/Target/ARM/ARMCodeEmitter.cpp
>> +++ lib/Target/ARM/ARMCodeEmitter.cpp
>>       break;
>>     ++NumRegs;
>>   }
>> -  Binary |= NumRegs * 2;
>> +  // bit 8 will be set if <list> is consecutive 64-bit registers (e.g.,
>> d0)
>> +  if(Binary & 0x100)
>> +    Binary |= NumRegs * 2;
>> +  else
>> +    Binary |= NumRegs;
>>
>>   emitWordLE(Binary);
>>  }
>>
>> Thanks.
>>
>
>


-- 
Thanks,
  Shih-wei
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100525/0f09867c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: arm-jit-vstm.patch
Type: text/x-patch
Size: 2089 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100525/0f09867c/attachment.bin>