[llvm-commits] [PATCH] ARM JIT: Add missing implementation to the materialization of VFP miscellaneous form instructions in JIT

[Zonr Chang]

Thanks for your approval and quick review on this patch.

Zonr


On Tue, May 25, 2010 at 4:50 PM, Shih-wei Liao <sliao at google.com> wrote:

> I reviewed and tested this patch.
>
> First, the code is good. (It corresponds to Table A7-18 in ARM Manual
> correctly.)
> Second, it passes all our tests. Thanks for the good patch.
> LGTM.
>
> On Sun, May 23, 2010 at 7:54 AM, Zonr Chang <zonr.xchg at gmail.com> wrote:
> > The attached patch adds missing implementation to the materialization of
> VFP
> > misc. instructions (i.e. instruction of the class VFPMiscFrm). This
> includes
> > vmrs, vmsr and vmov(immediate) (FCONSTD and FCONSTS). This patch should
> > resolve the PR7049 (http://llvm.org/bugs/show_bug.cgi?id=7049).
> >
> > P.S. Before you run the test code in PR7049, you may need to apply my
> > previous patch (arm-jit-movt-and-movw2.patch) first since printf(...)
> needs
> > movw/movt support. Changing "float" to "double" in test code also works.
> >
> >
> > Zonr
> > -------------- next part --------------
> > An HTML attachment was scrubbed...
> > URL:
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/attachments/20100523/15fc80f2/attachment.html
> > -------------- next part --------------
> > A non-text attachment was scrubbed...
> > Name: arm-jit-vfp-misc-inst.patch
> > Type: application/octet-stream
> > Size: 1838 bytes
> > Desc: not available
> > Url :
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/attachments/20100523/15fc80f2/attachment.obj
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100525/24d7621c/attachment.html>