[llvm-commits] [llvm] r103990 - in /llvm/trunk/lib: CodeGen/SelectionDAG/SelectionDAGISel.cpp Target/TargetMachine.cpp

[Duncan Sands]

Hi Bill,

> - Change the logic DisableFramePointerElim() to check for the
>    -disable-non-leaf-fp-elim before -disable-fp-elim.

doesn't this mean that if you specify both -disable-non-leaf-fp-elim
and -disable-fp-elim, then the frame pointer is eliminated for leaf
functions?  That's surely wrong since the user set -disable-fp-elim.

Ciao,

Duncan.

>     bool DisableFramePointerElim(const MachineFunction&MF) {
> -    if (NoFramePointerElim)
> -      return true;
> +    // Check to see if we should eliminate non-leaf frame pointers and then
> +    // check to see if we should eliminate all frame pointers.
>       if (NoFramePointerElimNonLeaf) {
>         const MachineFrameInfo *MFI = MF.getFrameInfo();
>         return MFI->hasCalls();
>       }
> -    return false;
> +
> +    return NoFramePointerElim;
>     }