[llvm-commits] [llvm-gcc-4.2] r103997 - /llvm-gcc-4.2/trunk/gcc/cp/mangle.c

[Dale Johannesen]

On May 17, 2010, at 4:37 PMPDT, Bob Wilson wrote:

> Author: bwilson
> Date: Mon May 17 18:37:16 2010
> New Revision: 103997
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=103997&view=rev
> Log:
> Look through typedefs when mangling NEON vector types.  The new arm_mangle_type
> implementation that looks for the builtin NEON types requires this.

Is this really safe in general?  I don't see anything limiting the effect to NEON vector types.

> Modified:
>    llvm-gcc-4.2/trunk/gcc/cp/mangle.c
> 
> Modified: llvm-gcc-4.2/trunk/gcc/cp/mangle.c
> URL: http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/cp/mangle.c?rev=103997&r1=103996&r2=103997&view=diff
> ==============================================================================
> --- llvm-gcc-4.2/trunk/gcc/cp/mangle.c (original)
> +++ llvm-gcc-4.2/trunk/gcc/cp/mangle.c Mon May 17 18:37:16 2010
> @@ -1591,7 +1591,7 @@
>   else
>     {
>       /* APPLE LOCAL begin mangle_type 7105099 */
> -      tree type_orig = type;
> +      /* LLVM LOCAL removed copy to type_orig */
> 
>       /* See through any typedefs.  */
>       type = TYPE_MAIN_VARIANT (type);
> @@ -1602,7 +1602,8 @@
>         {
> 	  /* Handle any target-specific fundamental types.  */
> 	  const char *target_mangling
> -	    = targetm.mangle_type (type_orig);
> +            /* LLVM LOCAL mangle based on TYPE_MAIN_VARIANT, not type_orig */
> +	    = targetm.mangle_type (type);
> 
> 	  if (target_mangling)
> 	    {
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits