[llvm-commits] New ScriptedBuilder patch

[Daniel Dunbar]

Hi Galina,

This seems more complicated than necessary. Since both sides are
Python code, there is no need for the assorted logic to handle import,
you could just pass the step to instantiate directly, instead of
passing the name of it. That is, have type just be the class to
instantiate, and call it like:
                                        {'name'          : 'test_llvm',
                                        'type'          :
zorg.buildbot.commands.ClangTestCommand.ClangTestCommand,
...

 - Daniel


On Fri, May 14, 2010 at 5:06 PM, Galina Kistanova <gkistanova at gmail.com> wrote:
> Hello,
>
> Please review patch to update one of existing builders and increase
> number of max_builds to 2 for the slave.
>
> Thanks
>
> Galina
>
>
> On Fri, May 14, 2010 at 4:47 PM, Galina Kistanova <gkistanova at gmail.com> wrote:
>> Hello everyone,
>>
>> Please review the patch for buildbot ScriptedBuilder.
>> It adds ability to specify type of command for build steps (for
>> example to use ClangTestCommand). By default steps are
>> WarningCountingShellCommand.
>>
>> I am going to send follow up patch for update builders to use this.
>>
>> Please review.
>>
>> Thanks
>>
>> Galina
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>