[llvm-commits] [llvm] r103757 - in /llvm/trunk: include/llvm/MC/MCParser/AsmParser.h include/llvm/MC/MCStreamer.h lib/MC/MCAsmStreamer.cpp lib/MC/MCMachOStreamer.cpp lib/MC/MCNullStreamer.cpp lib/MC/MCParser/AsmParser.cpp test/MC/AsmParser/directive_tbss.s

[Eric Christopher]

On May 15, 2010, at 8:27 PM, Chris Lattner wrote:

> On May 15, 2010, at 3:36 PM, Eric Christopher wrote:
>> Yeah, I was pretty unhappy about it and figured I'd be changing it.  The idea is that something like:
>> 
>> __thread a = 0;
>> 
>> will turn into:
>> 
>> .tbss _a+somemangling
> 
> Higher level things should handle the mangling.  MCStreamer should correspond to what the assembler parses.
> 
>> Another was:
>> 
>> void EmitTBSSSymbol(MCSymbol Sym, ...., StringRef Mangle)
>> 
>> but then I'm stuck trying to figure out which symbol I'm mangling.
> 
> It should take just a mcsymbol, size, and alignment.  The "mangling" should be handled at a higher level, just like it is for $stub's etc.

Cool.  No argument, just hadn't figured out how it needed to happen yet.  Thanks for the reminder on $stub, I'll look there.

-eric