[llvm-commits] [llvm] r103802 - in /llvm/trunk: include/llvm/CodeGen/ lib/CodeGen/ lib/CodeGen/AsmPrinter/ lib/CodeGen/SelectionDAG/ lib/Target/ lib/Target/ARM/ lib/Target/Blackfin/ lib/Target/CellSPU/ lib/Target/MBlaze/ lib/Target/MBlaze/AsmPrin

[Bill Wendling]

On May 14, 2010, at 2:43 PM, Anton Korobeynikov wrote:

>> Interesting. SystemZ is an example of where, when I change it to use a
>> "HasCalls" that's set correctly (i.e., it's set if there's any call, not
>> just an adjustment of the stack frame),
>> then test/CodeGen/SystemZ/2009-07-10-BadIncomingArgOffset.ll would
>> fail.
> It seems that test is wrong and new code is correct. On z/System the
> situation is the following: function uses the incoming stack frame to
> save any callee-saved registers. It's a responsibility of the caller
> to create such stack frame. The test in question contains calls, and
> it seems that these calls might overwrite the register save area (with
> the old code). So, please fix the test :)
> 
Okay. I'll trust on you to make sure that my fix is okay and that there aren't any regressions in z/System. :-)

-bw