[llvm-commits] COFF linkonce update

Anton Korobeynikov anton at korobeynikov.info
Wed May 12 00:05:20 PDT 2010


Hello, Nathan

> I would like to commit this patch as part of my ongoing work on improving
> COFF support in the MC library.
> This patch changes where the .linkonce attribute is emitted from the symbol
> to the section the symbol was assigned to.
Looks good for me as well.

+    //case IMAGE_COMDAT_SELECT_LARGEST:
+    //  OS << "\t.linkonce largest\n";
+    //  break;
Please move this case a fallthrough to default, with a proper comment.

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University



More information about the llvm-commits mailing list