[llvm-commits] [llvm] r103347 - in /llvm/trunk: lib/Transforms/Scalar/GVN.cpp test/Transforms/GVN/2010-05-08-OneBit.ll

Duncan Sands baldrick at free.fr
Sun May 9 01:13:50 PDT 2010


>> it looks like this should be
>>    uint64_t StoreSize = TD.getTypeStoreSize(SrcVal->getType());
>>
>>> +  uint64_t LoadSize = (TD.getTypeSizeInBits(LoadTy) + 7) / 8;
>>
>> and this
>>    uint64_t LoadSize = TD.getTypeStoreSize(LoadTy);
>
> I wasn't comfortable changing that without a testcase.  LoadSize should be the non-memory size I think, as in the other case, which has a testcase.

This is not a real change, getTypeStoreSize is defined to be equal to
(getTypeSizeInBits+7)/8.

Ciao,

Duncan.



More information about the llvm-commits mailing list