[llvm-commits] MCStreamer::EmitCOFFSymbolDef

Chris Lattner clattner at apple.com
Sat May 8 11:36:08 PDT 2010

On May 7, 2010, at 4:58 PM, Nathan Jeffords wrote:

> here is a patch that adds EmitCOFFSymbolDef to the MCStreamer interface this allows a symbols storage class & type to be set from the AsmPrinter without using EmitRawText. <EmitCOFFSymbolDef.patch>

Are you sure that this is better than emitting each directive individually?  Should def/scl/type/endef each be their own callbacks?

The MC design assumes that we want to build real native assemblers (if for no other reason, this makes it really easy to verify that the -filetype=obj and -filetype=asm paths are generating the same code).  If you start aggregating callbacks like this, we can't do this reasonably.

Another way of asking the question: if gas can handle these directives individually, why does the COFF emitter need them aggregated together?


More information about the llvm-commits mailing list