[llvm-commits] [PATCH] Bug fix in ARMISelDAGToDAG.cpp

Jim Grosbach grosbach at apple.com
Thu May 6 08:35:46 PDT 2010

On May 6, 2010, at 8:31 AM, Bob Wilson wrote:

> On May 6, 2010, at 4:14 AM, Edmund Grimley-Evans wrote:
>> The "break" in line 1869 used to fall through to the "return
>> SelectCode(N)" in line 1998, but then someone inserted the "case
>> ISD::CONCAT_VECTORS" so that it falls through to the "return
>> SelectConcatVector(N)" in line 1994 instead and much hilarity ensues.
>> This is one way of fixing it. Or you might prefer to insert a "break"
>> at line 1991, or even use a "goto".
> Thanks.  Of those options, I prefer inserting a break.  I'll put that in.

Beat ya to it! :D Feel free to change to whatever you prefer style-wise. I don't have a strong preference.

> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

More information about the llvm-commits mailing list