[llvm-commits] [llvm] r102946 - /llvm/trunk/lib/Analysis/ScalarEvolution.cpp

Dan Gohman gohman at apple.com
Wed May 5 11:01:17 PDT 2010


On May 4, 2010, at 12:15 AM, Duncan Sands wrote:

> Hi Dan,
> 
>> Also, pass true for isSigned even when creating constants for unsigned
>> comparisons, because the point is to create an all-ones constant,
>> rather than UINT64_MAX, even for integers wider than 64 bits.
> 
> why not use Constant::getAllOnesValue?

This is ScalarEvolution::getConstant, not ConstantInt::get. I guess a
ScalarEvolution::getAllOnesValue would be a useful helper function though.

Dan




More information about the llvm-commits mailing list