[llvm-commits] [llvm] r102941 - /llvm/trunk/lib/Target/X86/X86TargetMachine.cpp

[Eric Christopher]

On May 3, 2010, at 11:27 PM, Chris Lattner wrote:

> 
> On May 3, 2010, at 11:14 PM, Eric Christopher wrote:
> 
>>>> Ok, this seems more like something that should be a -mattr flag based on the CPU, not a random llc hook.
>>> 
>>> I don't think it's meant to be a permanent option, right? Eric, are you just toggling it for try to track down a bug?
>> 
>> I was yes, but I figured being able to turn it off might be of use for others to track down bugs.  Didn't think there was much overhead in adding a new option.  I can take it out if it's a problem.
> 
> 
> If this optimization pass makes sense for some cpu's but not others, then a -mattr makes the most sense.  Otherwise, I prefer to avoid random command line option hooks.
> 

OK.

-eric