[llvm-commits] [llvm] r102798 - in /llvm/trunk: lib/Analysis/InlineCost.cpp test/Transforms/Inline/2009-01-12-RecursiveInline.ll test/Transforms/Inline/noinline-recursive-fn.ll
Chris Lattner
clattner at apple.com
Fri Apr 30 16:01:07 PDT 2010
On Apr 30, 2010, at 3:51 PM, Dale Johannesen wrote:
>
> On Apr 30, 2010, at 3:37 PMPDT, Chris Lattner wrote:
>
>> Author: lattner
>> Date: Fri Apr 30 17:37:22 2010
>> New Revision: 102798
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=102798&view=rev
>> Log:
>> Dan recently disabled recursive inlining within a function, but we
>> were still inlining self-recursive functions into other functions.
>
> I don't much care about this, but why are we doing it? I don't recall a justification based on performance numbers. (When I enabled recursive inlining in the first place, I found it mostly affected small benchmarks like fib and factorial, but it can be a big win on those.)
I didn't disable inlining a recursive function "foo" into itself. I disabled inlining a recursive function "foo" into bar.
-Chris
More information about the llvm-commits
mailing list