[llvm-commits] [llvm] r102679 - /llvm/trunk/lib/ExecutionEngine/JIT/OProfileJITEventListener.cpp
Jeffrey Yasskin
jyasskin at google.com
Thu Apr 29 17:16:10 PDT 2010
Author: jyasskin
Date: Thu Apr 29 19:16:10 2010
New Revision: 102679
URL: http://llvm.org/viewvc/llvm-project?rev=102679&view=rev
Log:
Fix the OProfileJITEventListener build after r101844 removed
MachineFunction::DefaultDebugLoc. We now use the same technique as
DwarfDebug::beginFunction to find the starting line number for a
function.
Modified:
llvm/trunk/lib/ExecutionEngine/JIT/OProfileJITEventListener.cpp
Modified: llvm/trunk/lib/ExecutionEngine/JIT/OProfileJITEventListener.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/JIT/OProfileJITEventListener.cpp?rev=102679&r1=102678&r2=102679&view=diff
==============================================================================
--- llvm/trunk/lib/ExecutionEngine/JIT/OProfileJITEventListener.cpp (original)
+++ llvm/trunk/lib/ExecutionEngine/JIT/OProfileJITEventListener.cpp Thu Apr 29 19:16:10 2010
@@ -114,26 +114,43 @@
return;
}
- // Now we convert the line number information from the address/DebugLoc format
- // in Details to the address/filename/lineno format that OProfile expects.
- // OProfile 0.9.4 (and maybe later versions) has a bug that causes it to
- // ignore line numbers for addresses above 4G.
- FilenameCache Filenames;
- std::vector<debug_line_info> LineInfo;
- LineInfo.reserve(1 + Details.LineStarts.size());
- if (!Details.MF->getDefaultDebugLoc().isUnknown()) {
- LineInfo.push_back(LineStartToOProfileFormat(
- *Details.MF, Filenames,
- reinterpret_cast<uintptr_t>(FnStart),
- Details.MF->getDefaultDebugLoc()));
- }
- for (std::vector<EmittedFunctionDetails::LineStart>::const_iterator
+ if (!Details.LineStarts.empty()) {
+ // Now we convert the line number information from the address/DebugLoc
+ // format in Details to the address/filename/lineno format that OProfile
+ // expects. Note that OProfile 0.9.4 has a bug that causes it to ignore
+ // line numbers for addresses above 4G.
+ FilenameCache Filenames;
+ std::vector<debug_line_info> LineInfo;
+ LineInfo.reserve(1 + Details.LineStarts.size());
+
+ DebugLoc FirstLoc = Details.LineStarts[0].Loc;
+ assert(!FirstLoc.isUnknown()
+ && "LineStarts should not contain unknown DebugLocs");
+ MDNode *FirstLocScope = FirstLoc.getScope(F.getContext());
+ DISubprogram FunctionDI = getDISubprogram(FirstLocScope);
+ if (FunctionDI.Verify()) {
+ // If we have debug info for the function itself, use that as the line
+ // number of the first several instructions. Otherwise, after filling
+ // LineInfo, we'll adjust the address of the first line number to point at
+ // the start of the function.
+ debug_line_info line_info;
+ line_info.vma = reinterpret_cast<uintptr_t>(FnStart);
+ line_info.lineno = FunctionDI.getLineNumber();
+ line_info.filename = Filenames.getFilename(FirstLocScope);
+ LineInfo.push_back(line_info);
+ }
+
+ for (std::vector<EmittedFunctionDetails::LineStart>::const_iterator
I = Details.LineStarts.begin(), E = Details.LineStarts.end();
- I != E; ++I) {
- LineInfo.push_back(LineStartToOProfileFormat(
- *Details.MF, Filenames, I->Address, I->Loc));
- }
- if (!LineInfo.empty()) {
+ I != E; ++I) {
+ LineInfo.push_back(LineStartToOProfileFormat(
+ *Details.MF, Filenames, I->Address, I->Loc));
+ }
+
+ // In case the function didn't have line info of its own, adjust the first
+ // line info's address to include the start of the function.
+ LineInfo[0].vma = reinterpret_cast<uintptr_t>(FnStart);
+
if (op_write_debug_line_info(Agent, FnStart,
LineInfo.size(), &*LineInfo.begin()) == -1) {
DEBUG(dbgs()
More information about the llvm-commits
mailing list