[llvm-commits] [llvm] r102653 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

[Evan Cheng]

On Apr 29, 2010, at 11:50 AM, Devang Patel wrote:

> Author: dpatel
> Date: Thu Apr 29 13:50:36 2010
> New Revision: 102653
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=102653&view=rev
> Log:
> DO not push DBG_VALUE machine instructions for inlined fuction arguments in entry block.
> 
> Modified:
>    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
> 
> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp?rev=102653&r1=102652&r2=102653&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp (original)
> +++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp Thu Apr 29 13:50:36 2010
> @@ -3691,6 +3691,13 @@
>   if (!isa<Argument>(V))
>     return false;
> 
> +  // Ignore inlined function arguments here.
> +  DIVariable DV(Variable);
> +  if (DV.getContext().isSubprogram()
> +      && DISubprogram(DV.getContext().getNode()).getLinkageName()
> +      != cast<Argument>(V)->getParent()->getName())
> +    return false;

llvm (undocumented) convention is to put '&&' and '!=' at the end of the line. Also, can this check be factored into DebugInfo.h?

Evan

> +
>   MachineFunction &MF = DAG.getMachineFunction();
>   MachineBasicBlock *MBB = FuncInfo.MBBMap[DI.getParent()];
>   if (MBB != &MF.front())
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits