[llvm-commits] [llvm] r102509 - /llvm/trunk/lib/Target/X86/X86FloatingPoint.cpp

[Jakob Stoklund Olesen]

On Apr 28, 2010, at 12:42 PM, Chris Lattner wrote:

> 
> On Apr 28, 2010, at 11:28 AM, Jakob Stoklund Olesen wrote:
> 
>> Author: stoklund
>> Date: Wed Apr 28 13:28:37 2010
>> New Revision: 102509
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=102509&view=rev
>> Log:
>> Teach X86FloatingPoint that a register can be killed multiple times by the same
>> instruction.
>> 
>> This instruction would crash the pass:
>> 
>> INLINEASM <es:foo $0 $1>, 9, %FP0<kill>, 9, %FP0<kill>, 14, %EFLAGS<earlyclobber,def,dead>
>> 
>> Now it doesn't.
> 
> Great!  Testcase? :)

I fixed this because one of the existing test cases started failing with the r102510 patch, so there already is a test case :-)

It was inline-asm-fpstack.ll.

This kind of thing may show up again. After r102510, the coalescer can produce instructions with multiple kill flags on the same register. I decided that that was not an error, and anyone expecting only a single kill flag is mistaken.

/jakob