[llvm-commits] [llvm] r102365 - in /llvm/trunk: lib/CodeGen/AsmPrinter/AsmPrinter.cpp test/CodeGen/X86/alignment.ll test/CodeGen/X86/unaligned-load.ll

[Chris Lattner]

On Apr 27, 2010, at 5:23 AM, Duncan Sands wrote:

> Hi Chris,
> 
>> +  // If the alignment is specified, we *must* obey it.  Overaligning a global
>> +  // with a specified alignment is a prompt way to break globals emitted to
>> +  // sections and expected to be contiguous (e.g. ObjC metadata).
> 
> maybe this should be documented in the LangRef or somewhere else where people
> are likely to notice.  Thinking "increasing the alignment never hurts" is an
> easy thought to have.

You're right, it turns out that langref was actively wrong, fixed in r102474/102476.

> Also,  isn't there a pass that increases alignment?

Instcombine does this. Fixed in r102476.

-Chris