[llvm-commits] [llvm] r102468 - /llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

[Devang Patel]

On Apr 27, 2010, at 2:51 PM, Evan Cheng wrote:

> 
> On Apr 27, 2010, at 2:49 PM, Devang Patel wrote:
> 
>> Author: dpatel
>> Date: Tue Apr 27 16:49:04 2010
>> New Revision: 102468
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=102468&view=rev
>> Log:
>> Check operand type first.
>> 
>> Modified:
>>   llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
>> 
>> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=102468&r1=102467&r2=102468&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
>> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Tue Apr 27 16:49:04 2010
>> @@ -2083,7 +2083,8 @@
>>        continue;
>> 
>>      // Ignore Undef values.
>> -      if (!MInsn->getOperand(0).getReg())
>> +      if (MInsn->getOperand(0).getType() == MachineOperand::MO_Register
>> +          && !MInsn->getOperand(0).getReg())
> 
> It should be "MInsn->getOperand(0).isReg()" instead. Also, '&&' should be at the end of the first condition to conform to convention.

OK. Fixed.
-
Devang