[llvm-commits] [llvm] r101781 - /llvm/trunk/lib/System/Unix/Path.inc

[Chris Lattner]

On Apr 19, 2010, at 11:31 AM, Dan Gohman wrote:

> 
> On Apr 19, 2010, at 11:22 AM, Chris Lattner wrote:
> 
>> 
>> On Apr 19, 2010, at 8:54 AM, Dan Gohman wrote:
>> 
>>> Author: djg
>>> Date: Mon Apr 19 10:54:44 2010
>>> New Revision: 101781
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=101781&view=rev
>>> Log:
>>> Revert 91528 and use a std::vector instead, fixing an abuse of std::string.
>> 
>> How is std::vector better than std::string here?
> 
> libstdc++'s doxygen comment on basic_string's c_str() expresses the situation
> effectively:
> 
> "This is a handle to internal data. Do not modify or dire things may happen."

ok