[llvm-commits] [llvm] r101675 - in /llvm/trunk: lib/AsmParser/LLParser.cpp test/Bitcode/memcpy.ll

[Bob Wilson]

On Apr 17, 2010, at 2:38 PM, Nick Lewycky wrote:

> Daniel Dunbar wrote:
>> Author: ddunbar
>> Date: Sat Apr 17 16:24:55 2010
>> New Revision: 101675
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=101675&view=rev
>> Log:
>> Revert "reject forward references to functions whose type don't match", because DJG told me to!
> 
> Chris' patch was legitimately finding problems in our test suite. The 
> remaining buggy tests are test/CodeGen/ARM/{vst,vld}{1,2,3,4,lane}.ll . 
> Those should be fixed by someone who can verify the types on the 
> arm.neon intrinsics, after which point we can reinstate this patch.

Assuming it's not urgent, I'll take a look at it Monday.  The Neon load/store intrinsics all take i8* pointers.  I don't remember offhand if that was just laziness or something more significant.

> 
> Nick
> 
>> Modified:
>>     llvm/trunk/lib/AsmParser/LLParser.cpp
>>     llvm/trunk/test/Bitcode/memcpy.ll
>> 
>> Modified: llvm/trunk/lib/AsmParser/LLParser.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/AsmParser/LLParser.cpp?rev=101675&r1=101674&r2=101675&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/AsmParser/LLParser.cpp (original)
>> +++ llvm/trunk/lib/AsmParser/LLParser.cpp Sat Apr 17 16:24:55 2010
>> @@ -2787,10 +2787,6 @@
>>        ForwardRefVals.find(FunctionName);
>>      if (FRVI != ForwardRefVals.end()) {
>>        Fn = M->getFunction(FunctionName);
>> -      if (Fn->getType() != PFT)
>> -        return Error(FRVI->second.second, "invalid forward reference to "
>> -                     "function '" + FunctionName + "' with wrong type!");
>> -
>>        ForwardRefVals.erase(FRVI);
>>      } else if ((Fn = M->getFunction(FunctionName))) {
>>        // If this function already exists in the symbol table, then it is
>> 
>> Modified: llvm/trunk/test/Bitcode/memcpy.ll
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Bitcode/memcpy.ll?rev=101675&r1=101674&r2=101675&view=diff
>> ==============================================================================
>> --- llvm/trunk/test/Bitcode/memcpy.ll (original)
>> +++ llvm/trunk/test/Bitcode/memcpy.ll Sat Apr 17 16:24:55 2010
>> @@ -20,4 +20,4 @@
>> 
>>  declare void @llvm.memmove.i32(i8*, i8*, i32, i32)
>> 
>> -declare void @llvm.memmove.i64(i8*, i8*, i64, i32)
>> +declare void @llvm.memmove.i64(i8*, i8*, i32, i32)
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits