[llvm-commits] [llvm] r101563 - /llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp

Johnny Chen johnny.chen at apple.com
Fri Apr 16 16:02:25 PDT 2010


Author: johnny
Date: Fri Apr 16 18:02:25 2010
New Revision: 101563

URL: http://llvm.org/viewvc/llvm-project?rev=101563&view=rev
Log:
Fixed logic error.  Should check Builder for validity before calling SetSession
on it.

Modified:
    llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp

Modified: llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp?rev=101563&r1=101562&r2=101563&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp (original)
+++ llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp Fri Apr 16 18:02:25 2010
@@ -407,7 +407,6 @@
     });
 
   ARMBasicMCBuilder *Builder = CreateMCBuilder(Opcode, Format);
-
   if (!Builder)
     return false;
 
@@ -495,11 +494,11 @@
     });
 
   ARMBasicMCBuilder *Builder = CreateMCBuilder(Opcode, Format);
-  Builder->SetSession(const_cast<Session *>(&SO));
-
   if (!Builder)
     return false;
 
+  Builder->SetSession(const_cast<Session *>(&SO));
+
   if (!Builder->Build(MI, insn))
     return false;
 





More information about the llvm-commits mailing list