[llvm-commits] [llvm] r101299 - /llvm/trunk/include/llvm/IntrinsicInst.h

Dan Gohman gohman at apple.com
Wed Apr 14 16:43:06 PDT 2010



On Apr 14, 2010, at 3:27 PM, Dale Johannesen <dalej at apple.com> wrote:

>
> On Apr 14, 2010, at 3:23 PMPDT, Dan Gohman wrote:
>
>> Author: djg
>> Date: Wed Apr 14 17:23:05 2010
>> New Revision: 101299
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=101299&view=rev
>> Log:
>> Remove a const here. This makes this function consistent with all the
>> other getOperand wrappers, and it makes it easier to use with  
>> DebugInfo
>> code, which isn't currently prepared to see const MDNode *.
>
> Please don't do this.  The MDNode is not changing any more by the  
> time we get here, and should be referenced through const*; it's a  
> useful precaution.

DebugInfo does not use const on any of its MDNodes.  Should someone  
fix that, I'd happily revert this patch.

Dan




More information about the llvm-commits mailing list