[llvm-commits] [llvm] r100610 - /llvm/trunk/lib/CodeGen/MachineLICM.cpp

[Evan Cheng]

Author: evancheng
Date: Wed Apr  7 01:00:33 2010
New Revision: 100610

URL: http://llvm.org/viewvc/llvm-project?rev=100610&view=rev
Log:
Add comments for missed opportunities.

Modified:
    llvm/trunk/lib/CodeGen/MachineLICM.cpp

Modified: llvm/trunk/lib/CodeGen/MachineLICM.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineLICM.cpp?rev=100610&r1=100609&r2=100610&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/MachineLICM.cpp (original)
+++ llvm/trunk/lib/CodeGen/MachineLICM.cpp Wed Apr  7 01:00:33 2010
@@ -247,6 +247,8 @@
     if (!CurLoop->contains(BB))
       continue;
     // Conservatively treat live-in's as an external def.
+    // FIXME: That means a reload that's reused into a fallthrough block
+    // will not be LICM'ed.
     for (MachineBasicBlock::const_livein_iterator I = BB->livein_begin(),
            E = BB->livein_end(); I != E; ++I) {
       unsigned Reg = *I;
@@ -282,7 +284,8 @@
         }
       }
 
-      // FIXME: Only consider reloads for now.
+      // FIXME: Only consider reloads for now. We should be able to handle
+      // remat which does not have register operands.
       bool SkipCheck = false;
       int FI;
       if (SeenDef && !RuledOut) {