[llvm-commits] [llvm] r100606 - /llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp

Chris Lattner sabre at nondot.org
Tue Apr 6 22:27:36 PDT 2010


Author: lattner
Date: Wed Apr  7 00:27:36 2010
New Revision: 100606

URL: http://llvm.org/viewvc/llvm-project?rev=100606&view=rev
Log:
remove another magic number.

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp?rev=100606&r1=100605&r2=100606&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp Wed Apr  7 00:27:36 2010
@@ -167,10 +167,9 @@
         break;
       case '(':             // $( -> same as GCC's { character.
         ++LastEmitted;      // Consume '(' character.
-        if (CurVariant != -1) {
+        if (CurVariant != -1)
           llvm_report_error("Nested variants found in inline asm string: '"
                             + std::string(AsmStr) + "'");
-        }
         CurVariant = 0;     // We're in the first variant now.
         break;
       case '|':
@@ -273,7 +272,7 @@
             OS << *MI->getOperand(OpNo).getMBB()->getSymbol();
           else {
             AsmPrinter *AP = const_cast<AsmPrinter*>(this);
-            if ((OpFlags & 7) == 4) {
+            if (InlineAsm::isMemKind(OpFlags)) {
               Error = AP->PrintAsmMemoryOperand(MI, OpNo, AsmPrinterVariant,
                                                 Modifier[0] ? Modifier : 0,
                                                 OS);





More information about the llvm-commits mailing list