[llvm-commits] [llvm] r100455 - in /llvm/trunk: lib/CodeGen/MachineSink.cpp test/CodeGen/X86/unreachable-loop-sinking.ll

[Dan Gohman]

On Apr 5, 2010, at 12:55 PM, Jakob Stoklund Olesen wrote:

> 
> On Apr 5, 2010, at 12:17 PM, Dan Gohman wrote:
> 
>> Author: djg
>> Date: Mon Apr  5 14:17:22 2010
>> New Revision: 100455
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=100455&view=rev
>> Log:
>> Don't do code sinking on unreachable blocks. It's unprofitable and hazardous.
> 
> Should we be running UnreachableBlockElim earlier?

It's nice to avoid dependencies like that when convenient. If someone
had an alternative liveness analysis which tolerated unreachable
blocks, then they wouldn't require UnreachableBlockElim at all.
But it's not critical.

Dan