[llvm-commits] [llvm] r100315 - in /llvm/trunk/lib/Target/X86/AsmPrinter: X86AsmPrinter.h X86MCInstLower.cpp

Dale Johannesen dalej at apple.com
Mon Apr 5 13:45:35 PDT 2010

On Apr 5, 2010, at 1:09 PMPDT, Chris Lattner wrote:

> On Apr 5, 2010, at 11:09 AM, Devang Patel wrote:
>>>> Ideally, there should be a target independent way to print DBG_VALUE machine instructions as comments.
>>> Do we actually want this long term?  I've been regarding the comments as a hack that will go away when the Dwarf writer knows how to deal with dbg_value.
>> At the moment, the DwarfDebug does not remove them from the instruction stream. The nice thing about printing comment is that it is only printed when -verbose-asm is used.
> I completely agree devang, they should be printed as comments (by target independent code) when verbose asm is enabled.  I pointed this out a long time ago.

Lowering dbg_declare to DBG_VALUE produces a target-dependent form, so that won't entirely work. Devang has decided we don't need to do this for now, though; what is currently used can be done target-independent.  The consensus seems to be to keep the comments, so I'll move the code up.

More information about the llvm-commits mailing list