[llvm-commits] [llvm] r100072 - in /llvm/trunk: include/llvm/Support/DebugLoc.h lib/VMCore/DebugLoc.cpp lib/VMCore/LLVMContextImpl.h

[Chris Lattner]

On Mar 31, 2010, at 5:45 PM, Dale Johannesen wrote:

> 
> On Mar 31, 2010, at 5:37 PMPDT, Chris Lattner wrote:
>>>  class NewDebugLoc {
>> +    /// LineCol - This 32-bit value encodes the line and column number for the
>> +    /// location, encoded as 24-bits for line and 8 bits for col.  A value of 0
>> +    /// for either means unknown.
>> +    unsigned LineCol;
>> +    
> 
> Machine-generated code often goes over 255 columns.   Are you sure you want to design this limitation in?

Yep.  Only clang generates column numbers, and I don't know of any debuggers that do anything with them.  We can always change this in the future.

-Chris