[llvm-commits] [llvm] r99848 - in /llvm/trunk/lib/Target/X86: SSEDomainFix.cpp X86InstrInfo.cpp X86InstrInfo.h
Chris Lattner
clattner at apple.com
Wed Mar 31 15:27:44 PDT 2010
On Mar 31, 2010, at 1:59 PM, Jakob Stoklund Olesen wrote:
>>
>> Please put DomainValue in an anonymous namespace.
>
> Everything already is. Should I open a new namespace per class to make it more obvious?
Ah yes, please do. I prefer to keep anon namespaces and tight as possible around the classes they protect, it makes it easier to tell what is or isn't in one.
Thanks!
-Chris
More information about the llvm-commits
mailing list