[llvm-commits] [llvm] r99883 - in /llvm/trunk: include/llvm/CodeGen/LiveInterval.h include/llvm/Support/Allocator.h lib/CodeGen/LiveInterval.cpp lib/CodeGen/LiveIntervalAnalysis.cpp lib/Support/Allocator.cpp

[Chris Lattner]

On Mar 31, 2010, at 5:13 AM, Török Edwin wrote:

> On 03/30/2010 09:33 PM, Chris Lattner wrote:
>> On Mar 30, 2010, at 4:17 AM, Torok Edwin wrote:
>> 
>>> Author: edwin
>>> Date: Tue Mar 30 06:17:48 2010
>>> New Revision: 99883
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=99883&view=rev
>>> Log:
>>> Reapply r99881 with some fixes: only call destructor in releaseMemory!
>> 
>> Edwin, this patch isn't safe at all.  What if you allocate different types in one bump pointer? 
> 
> Jakob and Benjamin have addressed that issue in r99919, I'll have a look
> at that commit shortly.
> 
>> Please revert it.
> 
> Is r99919 unsafe too? I can revert both then.

SpecificBumpAllocator seems right to me, thanks all!

-Chris