[llvm-commits] [llvm] r99542 - /llvm/trunk/lib/Target/X86/SSEDomainFix.cpp

[Jakob Stoklund Olesen]

On Mar 25, 2010, at 1:11 PM, Bill Wendling wrote:

> On Mar 25, 2010, at 12:35 PM, Daniel Dunbar wrote:
> 
>> Author: ddunbar
>> Date: Thu Mar 25 14:35:53 2010
>> New Revision: 99542
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=99542&view=rev
>> Log:
>> Fix -Asserts warning, again.
>> 
>> Modified:
>>   llvm/trunk/lib/Target/X86/SSEDomainFix.cpp
>> 
>> Modified: llvm/trunk/lib/Target/X86/SSEDomainFix.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/SSEDomainFix.cpp?rev=99542&r1=99541&r2=99542&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Target/X86/SSEDomainFix.cpp (original)
>> +++ llvm/trunk/lib/Target/X86/SSEDomainFix.cpp Thu Mar 25 14:35:53 2010
>> @@ -87,6 +87,7 @@
>>      MachineInstr *MI = I;
>>      const unsigned *equiv = 0;
>>      X86InstrInfo::SSEDomain domain = TII->GetSSEDomain(MI, equiv);
>> +      (void) domain;
>>      DEBUG(dbgs() << "-isd"[domain] << (equiv ? "* " : "  ") << *MI);
> 
> Why not put the "domain" definition inside of the DEBUG macro? Comme ça:
> 
>  DEBUG({
>    X86InstrInfo::SSEDomain domain = TII->GetSSEDomain(MI, equiv);
>    dbgs() << "-isd"[domain] << (equiv ? "* " : "  ") << *MI;
>  });

That would work too.

This is just skeleton code that is going away immediately, so anything that keeps the compiler quiet is fine by me.

/jakob