[llvm-commits] [test-suite] r99329 - /test-suite/trunk/TEST.m2regllcdbg.Makefile

[Bill Wendling]

On Mar 23, 2010, at 4:01 PM, Chris Lattner wrote:

> On Mar 23, 2010, at 3:03 PM, Bill Wendling wrote:
> 
>> On Mar 23, 2010, at 2:41 PM, Chris Lattner wrote:
>> 
>>> On Mar 23, 2010, at 2:36 PM, Bill Wendling wrote:
>>> 
>>>> Author: void
>>>> Date: Tue Mar 23 16:36:36 2010
>>>> New Revision: 99329
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=99329&view=rev
>>>> Log:
>>>> Remove "crit_edge*" comments. These could change, but they don't effect code
>>>> generation.
>>> 
>>> Are you checking the -fverbose-asm output or something or do these comments come out even when verbose-asm is disabled?  If they're coming out with verbose-asm off, we should fix that.
>>> 
>> This is the result of "llc", which has verbose-asm on by default as far as I can tell. We aren't checking the output of the comments in general. We do check them for DWARF debugging info, which is really only readable in comments. (That's my understanding. Devang can correct me if I'm wrong.)
> 
> Can you just disable verbose asm then?  Alternatively, just run through llvm-mc which will read the .s file then print it back out (without comments) to canonicalize it?
> 
As Dale mentioned, it could potentially hide code optimizations / generation that's behaving differently when debugging info is introduced. We don't need 100% compliance with comments, but there are some key things we should watch out for, it seems. And those are available only in comments (from what I understand).

-bw