[llvm-commits] [zorg] r99105 - /zorg/trunk/zorg/buildbot/commands/ClangTestCommand.py

[Daniel Dunbar]

Author: ddunbar
Date: Sat Mar 20 19:59:52 2010
New Revision: 99105

URL: http://llvm.org/viewvc/llvm-project?rev=99105&view=rev
Log:
Don't hardcode name of ClangTestCommand (which is really the 'lit' test command,
now), and add some FIXMEs.

Modified:
    zorg/trunk/zorg/buildbot/commands/ClangTestCommand.py

Modified: zorg/trunk/zorg/buildbot/commands/ClangTestCommand.py
URL: http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/commands/ClangTestCommand.py?rev=99105&r1=99104&r2=99105&view=diff
==============================================================================
--- zorg/trunk/zorg/buildbot/commands/ClangTestCommand.py (original)
+++ zorg/trunk/zorg/buildbot/commands/ClangTestCommand.py Sat Mar 20 19:59:52 2010
@@ -5,9 +5,9 @@
 import buildbot
 import buildbot.steps.shell
 
+# FIXME: Rename to LitTestCommand.
 class ClangTestCommand(buildbot.steps.shell.Test):
-  description = "testing clang"
-  descriptionDone = "test clang"
+  # FIXME: We should process things in a test observer instead of at the end.
 
   kTestLineRE = re.compile(r'([^ ]*): (.*) \(.*.*\)')
   kTestFailureLogStartRE = re.compile(r"""\*{4,80} TEST '(.*)' .*""")
@@ -62,14 +62,14 @@
     for name,items in failureLogs[:self.kMaxFailureLogs]:
       self.addCompleteLog(os.path.basename(name.lower()),
                           ''.join(items) + '\n')
-      
+
     numPass = len(grouped.get('PASS',()))
     numFail = len(grouped.get('FAIL',()))
     numXFail = len(grouped.get('XFAIL',()))
     numXPass = len(grouped.get('XPASS',()))
-    self.setTestResults(total=numPass + numFail + numXFail + numXPass, 
-                        failed=numFail + numXPass, 
-                        passed=numPass + numXFail, 
+    self.setTestResults(total=numPass + numFail + numXFail + numXPass,
+                        failed=numFail + numXPass,
+                        passed=numPass + numXFail,
                         warnings=numXFail)
     if numFail + numXPass:
       return buildbot.status.builder.FAILURE