[llvm-commits] Extract MachObjectWriter class to own header and code files

[Aaron Gray]

On 15 March 2010 22:32, Bill Wendling <wendling at apple.com> wrote:

> On Mar 15, 2010, at 10:06 AM, Aaron Gray wrote:
>
> > Hi,
> >
> > This patch extracts 'class MachObjectWriter' into its own .h and .cpp
> files.
> >
> > Tested on MSVC and Cygwin.
> >
> Hi Aaron,
>
> I'll let Chris & Daniel comment on the rest, but:
>
> Index: lib/CodeGen/TargetLoweringObjectFileImpl.cpp
> ===================================================================
> --- lib/CodeGen/TargetLoweringObjectFileImpl.cpp        (revision 98543)
> +++ lib/CodeGen/TargetLoweringObjectFileImpl.cpp        (working copy)
> @@ -469,6 +469,7 @@
>   // Otherwise, return a new section.
>   return Entry = MCSectionMachO::Create(Segment, Section,
> TypeAndAttributes,
>                                         Reserved2, Kind, getContext());
> +  assert( Entry != 0 && "MCSectionMachO::Create returns zero");
>  }
>
> The assert is dead code.


Yes, that is not very good, I thought I had got rid of that :(

Aaron
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100316/921416b0/attachment.html>