[llvm-commits] [llvm] r98550 - /llvm/trunk/lib/CodeGen/UnreachableBlockElim.cpp

[Chris Lattner]

On Mar 15, 2010, at 11:34 AM, Dan Gohman wrote:

> 
> On Mar 15, 2010, at 9:37 AM, Chris Lattner wrote:
> 
>> Author: lattner
>> Date: Mon Mar 15 11:37:42 2010
>> New Revision: 98550
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=98550&view=rev
>> Log:
>> don't eliminate address-taken blocks here.
> 
> IIRC, the main reason for UnreachableBlockElim is that CodeGen's liveness analysis
> requires all blocks be reachable. If address-taken blocks have no CFG predecessors
> and aren't deleted, wouldn't it re-introduce the problems UnreachableBlockElim was
> intended to solve?

CGP generally deletes blocks as well, but you're right and this patch isn't required anyway.  I reverted it.