[llvm-commits] [llvm] r98384 - in /llvm/trunk: include/llvm/MC/MCAsmInfo.h lib/MC/MCAsmInfo.cpp lib/MC/MCAsmInfoCOFF.cpp lib/Target/Mangler.cpp lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp lib/Target/X86/AsmPrinter/X86MCInstLower.cpp lib/Target/X8

[Chris Lattner]

On Mar 12, 2010, at 2:05 PM, Anton Korobeynikov wrote:

> Hi, Chris
> 
>> +      // fastcall functions need to start with @.
>> +      // FIXME: This logic seems unlikely to be right.
>> +      if (CC == CallingConv::X86_FastCall) {
>> +        if (OutName[0] == '_')
>> +          OutName[0] = '@';
>> +        else
>> +          OutName.insert(OutName.begin(), '@');
> No, the logic is correct. We mangle foo to _foo at N for stdcall and
> @foo at N for fastcall. However, if there is not underscore in the
> beginning of the mangled name we should add @ as well. This ugly, yes
> :(

Even with the GNU __asm renaming extension??

-Chris