[llvm-commits] [llvm] r98368 - /llvm/trunk/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp

[Chris Lattner]

Anton, this means that this code is dead:

     // Emit type information for external functions
    for (X86COFFMachineModuleInfo::stub_iterator I = COFFMMI.stub_begin(),
           E = COFFMMI.stub_end(); I != E; ++I) {
      O << "\t.def\t " << I->getKeyData()
        << ";\t.scl\t" << COFF::C_EXT
        << ";\t.type\t" << (COFF::DT_FCN << COFF::N_BTSHFT)
        << ";\t.endef\n";
    }

Is this really true?  If so, we should remove the COFFMMI stub stuff.

-Chris

On Mar 12, 2010, at 11:14 AM, Chris Lattner wrote:

> Author: lattner
> Date: Fri Mar 12 13:14:18 2010
> New Revision: 98368
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=98368&view=rev
> Log:
> Remove some dead code.  This method only gets called on 
> definitions.
> 
> 
> Modified:
>    llvm/trunk/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp
> 
> Modified: llvm/trunk/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp?rev=98368&r1=98367&r2=98368&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp Fri Mar 12 13:14:18 2010
> @@ -63,11 +63,6 @@
>     MMI->getObjFileInfo<X86COFFMachineModuleInfo>();
>   COFFMMI.DecorateCygMingName(Symb, OutContext, GV, *TM.getTargetData());
> 
> -  // Save function name for later type emission.
> -  const Function *F = cast<Function>(GV);
> -  if (F->isDeclaration())
> -    COFFMMI.addExternalFunction(Symb->getName());
> -
>   return Symb;
> }
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits