[llvm-commits] [llvm] r98240 - in /llvm/trunk: include/llvm/MC/MCAsmLayout.h lib/MC/MCAssembler.cpp

[Daniel Dunbar]

Author: ddunbar
Date: Wed Mar 10 23:53:33 2010
New Revision: 98240

URL: http://llvm.org/viewvc/llvm-project?rev=98240&view=rev
Log:
MC/Mach-O: Start passing in the basic MCAsmLayout object.
 - Also, drop the current location part of AsmLayout, I think I prefer to implement this via explicit symbols.

Modified:
    llvm/trunk/include/llvm/MC/MCAsmLayout.h
    llvm/trunk/lib/MC/MCAssembler.cpp

Modified: llvm/trunk/include/llvm/MC/MCAsmLayout.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCAsmLayout.h?rev=98240&r1=98239&r2=98240&view=diff
==============================================================================
--- llvm/trunk/include/llvm/MC/MCAsmLayout.h (original)
+++ llvm/trunk/include/llvm/MC/MCAsmLayout.h Wed Mar 10 23:53:33 2010
@@ -22,26 +22,13 @@
 /// even during the relaxation process.
 class MCAsmLayout {
 private:
-  uint64_t CurrentLocation;
-
   MCAssembler &Assembler;
 
 public:
-  MCAsmLayout(MCAssembler &_Assembler)
-    : CurrentLocation(0), Assembler(_Assember) {}
+  MCAsmLayout(MCAssembler &_Assembler) : Assembler(_Assembler) {}
 
   /// Get the assembler object this is a layout for.
   MCAssembler &getAssembler() { return Assembler; }
-
-  /// Get the current location value, i.e. that value of the '.' expression.
-  uin64_t getCurrentLocation() {
-    return CurrentLocation;
-  }
-
-  /// Set the current location.
-  void setCurrentLocation(uint64_t Value) {
-    CurrentLocation = Value;
-  }
 };
 
 } // end namespace llvm

Modified: llvm/trunk/lib/MC/MCAssembler.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAssembler.cpp?rev=98240&r1=98239&r2=98240&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCAssembler.cpp (original)
+++ llvm/trunk/lib/MC/MCAssembler.cpp Wed Mar 10 23:53:33 2010
@@ -9,6 +9,7 @@
 
 #define DEBUG_TYPE "assembler"
 #include "llvm/MC/MCAssembler.h"
+#include "llvm/MC/MCAsmLayout.h"
 #include "llvm/MC/MCExpr.h"
 #include "llvm/MC/MCSectionMachO.h"
 #include "llvm/MC/MCSymbol.h"
@@ -510,8 +511,11 @@
     unsigned IsPCRel = isFixupKindPCRel(Fixup.Kind);
     unsigned Log2Size = getFixupKindLog2Size(Fixup.Kind);
 
+    // FIXME: Share layout object.
+    MCAsmLayout Layout(Asm);
+
     MCValue Target;
-    if (!Fixup.Value->EvaluateAsRelocatable(Target))
+    if (!Fixup.Value->EvaluateAsRelocatable(Target, &Layout))
       llvm_report_error("expected relocatable expression");
 
     // If this is a difference or a defined symbol plus an offset, then we need
@@ -1001,6 +1005,7 @@
 }
 
 void MCAssembler::LayoutSection(MCSectionData &SD) {
+  MCAsmLayout Layout(*this);
   uint64_t Address = SD.getAddress();
 
   for (MCSectionData::iterator it = SD.begin(), ie = SD.end(); it != ie; ++it) {
@@ -1029,21 +1034,17 @@
     case MCFragment::FT_Org: {
       MCOrgFragment &OF = cast<MCOrgFragment>(F);
 
-      MCValue Target;
-      if (!OF.getOffset().EvaluateAsRelocatable(Target))
-        llvm_report_error("expected relocatable expression");
-
-      if (!Target.isAbsolute())
-        llvm_unreachable("FIXME: Not yet implemented!");
-      uint64_t OrgOffset = Target.getConstant();
-      uint64_t Offset = Address - SD.getAddress();
+      int64_t TargetLocation;
+      if (!OF.getOffset().EvaluateAsAbsolute(TargetLocation, &Layout))
+        llvm_report_error("expected assembly-time absolute expression");
 
       // FIXME: We need a way to communicate this error.
-      if (OrgOffset < Offset)
-        llvm_report_error("invalid .org offset '" + Twine(OrgOffset) +
-                          "' (at offset '" + Twine(Offset) + "'");
+      int64_t Offset = TargetLocation - F.getOffset();
+      if (Offset < 0)
+        llvm_report_error("invalid .org offset '" + Twine(TargetLocation) +
+                          "' (at offset '" + Twine(F.getOffset()) + "'");
 
-      F.setFileSize(OrgOffset - Offset);
+      F.setFileSize(Offset);
       break;
     }