[llvm-commits] [llvm] r86748 - in /llvm/trunk: include/llvm/Analysis/ include/llvm/CodeGen/ include/llvm/Transforms/Utils/ lib/Analysis/ lib/CodeGen/AsmPrinter/ lib/CodeGen/SelectionDAG/ lib/Transforms/Utils/

[Jeffrey Yasskin]

On Wed, Mar 10, 2010 at 4:43 PM, Devang Patel <dpatel at apple.com> wrote:
>
> On Mar 10, 2010, at 3:58 PM, Jeffrey Yasskin wrote:
>
>> On Mon, Mar 8, 2010 at 10:13 AM, Devang Patel <dpatel at apple.com> wrote:
>>> Hi Jeffrey,
>>>
>>> I'll update the comment. AbstractScopes map is used to keep track of abstract scopes in entire module. AbstractScopesList is used to construct abstract scopes seen while processing a function. This use of list avoids randomness in DIE ordering.
>>
>> Thanks.  Is there a test for this ordering stability?
>
> You mean test to reason why we use list instead of map because of ordering requirement ?

I'm not exactly sure how to parse that question, so sorry if this
isn't an appropriate answer, but I mean something under either test/
or unittests/ that would fail if anyone removed the list or used the
map where they should have used the list. For example, it could llc a
file with several scopes and CHECK that the DW_whatevers appeared in a
particular order. That would overspecify the requirement, I think, and
so would need to be updated any time the logic changed, but it would
fail if the output order depended on anything but the input.

Jeffrey